Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): correct module while generating a feature #4289

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

The current steps on the website result in an error. https://ngrx.io/guide/schematics/feature

ng generate module User --flat false
ng generate feature user/User -m user.module.ts --group

Closes #4281

What is the new behavior?

The feature schematic creates and updates the desired files:

image

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 220e556
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/660d9df4ac13fd0008f6e822

@markostanimirovic markostanimirovic merged commit 7ecffe8 into main Apr 8, 2024
5 checks passed
@markostanimirovic markostanimirovic deleted the fix/feature-schematic-generation branch April 8, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot generate feature inside module with schematics
3 participants