Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component-store): add migrator for tapResponse #4321

Conversation

rainerhahnekamp
Copy link
Contributor

Migrates any import of tapResponse from @ngrx/component-store to @ngrx/operators.

I have done this in the same way as the migrator of concatLatestFrom in #4311. So, in the end, it is a better copy & paste.

I could also come up with a generic function that we could reuse for other potential, similar migrations.

Fixes #4261

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

Closes #4261

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Migrates any `import` of `tapResponse` from `@ngrx/component-store`
to `@ngrx/operators`.

Fixes ngrx#4261
Copy link

netlify bot commented May 8, 2024

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit aafeb36
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/663bf87e23157c0008007b69

Copy link
Member

@markostanimirovic markostanimirovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks Rainer! 🚀

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@timdeschryver timdeschryver merged commit 0ae21c9 into ngrx:main May 9, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ngrx/component-store: Add migration schematic for tapResponse operator
3 participants