Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): add as devDependency via ng add #4343

Merged
merged 1 commit into from
May 17, 2024

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #4322

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

There's no test because the schematic runner doesn't update the package.json file.
I verified this change locally.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 6043709
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/664635b92d355900083b762f

@brandonroberts brandonroberts merged commit 4fe7b7f into main May 17, 2024
5 checks passed
@brandonroberts brandonroberts deleted the eslint-as-dev branch May 17, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng add @ngrx/eslint-plugin adds to dependencies instead of devDependencies
3 participants