-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signals): replace idKey
with selectId
when defining custom entity ID
#4396
Merged
markostanimirovic
merged 3 commits into
main
from
feat/signals/replace-idKey-with-selectId
Jun 18, 2024
Merged
feat(signals): replace idKey
with selectId
when defining custom entity ID
#4396
markostanimirovic
merged 3 commits into
main
from
feat/signals/replace-idKey-with-selectId
Jun 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ngrx-io ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
5159c52
to
ba01d4e
Compare
timdeschryver
approved these changes
Jun 17, 2024
projects/ngrx.io/content/guide/signals/signal-store/entity-management.md
Outdated
Show resolved
Hide resolved
projects/ngrx.io/content/guide/signals/signal-store/entity-management.md
Outdated
Show resolved
Hide resolved
brandonroberts
approved these changes
Jun 17, 2024
…agement.md Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
…agement.md Co-authored-by: Tim Deschryver <28659384+timdeschryver@users.noreply.github.com>
ccc8655
to
02d0585
Compare
gisbdzhch
pushed a commit
to gisktzh/gb3-web_ui
that referenced
this pull request
Aug 13, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@ngrx/schematics](https://github.com/ngrx/platform) | devDependencies | major | [`^17.1.1` -> `^18.0.0`](https://renovatebot.com/diffs/npm/@ngrx%2fschematics/17.2.0/18.0.1) | --- ### Release Notes <details> <summary>ngrx/platform (@​ngrx/schematics)</summary> ### [`v18.0.1`](https://github.com/ngrx/platform/blob/HEAD/CHANGELOG.md#1801-2024-06-27) [Compare Source](ngrx/platform@18.0.0...18.0.1) ##### Bug Fixes - **component-store:** resolve issues in migration script to v18 ([#​4403](ngrx/platform#4403)) ([a15d53e](ngrx/platform@a15d53e)) - **effects:** fix bugs in migration script to v18 ([#​4402](ngrx/platform#4402)) ([6ae4723](ngrx/platform@6ae4723)) - **eslint-plugin:** only take return statement into account with no-multiple-actions-in-effects ([#​4410](ngrx/platform#4410)) ([c9c646c](ngrx/platform@c9c646c)), closes [#​4409](ngrx/platform#4409) ##### Features - **signals:** rename signals to computed when defining custom features with input ([#​4395](ngrx/platform#4395)) ([05f0940](ngrx/platform@05f0940)), closes [#​4391](ngrx/platform#4391) - **signals:** replace `idKey` with `selectId` when defining custom entity ID ([#​4396](ngrx/platform#4396)) ([67a5a93](ngrx/platform@67a5a93)), closes [#​4217](ngrx/platform#4217) [#​4392](ngrx/platform#4392) ### [`v18.0.0`](https://github.com/ngrx/platform/blob/HEAD/CHANGELOG.md#1800-2024-06-13) [Compare Source](ngrx/platform@17.2.0...18.0.0) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or rename PR to start with "rebase!". 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
The custom entity id is defined using the
idKey
property:Closes #4217, #4392
What is the new behavior?
The custom entity id is defined using the
selectId
function:Does this PR introduce a breaking change?
Other information
This is not considered as a breaking change because the
@ngrx/signals
package is in developer preview.