@ngrx/router-store triggers unexpected ROUTER_CANCEL action if store is modified by guard .

[majo44]

I'm submitting a...

[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

If the store is asynchronously modified by route guard, during the transition StoreRouterConnectingModule is executing navigateByUrl on router, because the url set in state by StoreRouterConnectingModule (taken from NavigationStart event) is different than router.url value (which contains url from before of transition). This cause cancellation of previous navigation, and next try to execute the navigation (for same url), and again and again, until the guard will not return true synchronously.

Please look at code https://github.com/ngrx/platform/blob/master/modules/router-store/src/router_store_module.ts#L209

Expected behavior:

StoreRouterConnectingModule should not trigger navigateByUrl if state is modified by guard.

Minimal reproduction of the problem with instructions:

Please look at: http://plnkr.co/edit/SbecXWSzFMnSRA9JFQ0i

Version of affected browser(s),operating system(s), npm, node and ngrx:

latest

Other information:

[brandonroberts]

Can you make a small repro?

[majo44]

Sample added.
http://plnkr.co/edit/SbecXWSzFMnSRA9JFQ0i

[brandonroberts]

This issue has already been fixed in master and will be in the next release. #355

[soyuka]

When will it be released? Thanks.

[antl3x]

I keep getting this error even with new master.

[demirtasg]

this issue is still not resolved

[pfeileon]

I'm refactoring an app from excessive resolver-use to NgRx and get unexpected navigation cancelled events, as well, even though the resolvers themselves don't even inject the store. Since I'll make all resolvers non-blocking and use them as a hook to dispatch actions more or less declaratively via the route config, it won't be an issue for me, but there's definitely still something wrong.