Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement ngrx rules for @angular-devkit/schematics #53

Closed
robwormald opened this issue Jul 2, 2017 · 9 comments
Closed

Implement ngrx rules for @angular-devkit/schematics #53

robwormald opened this issue Jul 2, 2017 · 9 comments
Assignees

Comments

@robwormald
Copy link
Contributor

Pretty soon here the Angular team will be releasing Schematics, a new library for doing code generation and modification. It's the tool Angular CLI will use for generating components, tests, etc.

It's extensible, so we should develop a set of Rules for schematics that handle some of the boilerplate of ngrx. Things like:

  • generating reducers and tests
  • generating reducers w/ a set of passed actions
  • generating CRUD-reducers
  • creating effects
  • etc

This is blocked proper until a release of Schematics, but feedback on what kind of rules would be useful is welcome.

@sharikovvladislav
Copy link
Contributor

This news are awesome! Can't wait I can try this and probably help with testing :)

  1. Do you have any information about the possible release dates of the library?
  2. I think that a rule to create "feature module" might be useful. I mean some command that will create whole feature module with some base structure (reducer, effects file, actions file, core module, core container may be).

@sharikovvladislav
Copy link
Contributor

@robwormald Any plans on this? Schematics was shipped in cli 1.4 if I remember correctly.

@brandonroberts brandonroberts self-assigned this Oct 19, 2017
@ghost
Copy link

ghost commented Nov 27, 2017

I love @ngrx/platform; however, my only concern since the release of these state management packages has been the documentation. To be more specific, I feel the documentation and corresponding samples could be more clear and concise. Presently, it seems lack of clarity in the documentation surfaces as project filesystem structures begin to deviate from the shape of the example-app. I know the documentation is revised continuously. I believe it would of benefit to newcomers if the documentation more closely represented the official angular documentation of the format from angular.io guides. It would be awesome to see @ngrx/platform documentation as it relates to Schematics rules upon release take the initiative to supply the aforementioned documentation format to promote ease of adoption.

brandonroberts added a commit that referenced this issue Dec 5, 2017
brandonroberts added a commit that referenced this issue Dec 5, 2017
brandonroberts added a commit that referenced this issue Dec 5, 2017
brandonroberts added a commit that referenced this issue Dec 5, 2017
brandonroberts added a commit that referenced this issue Dec 5, 2017
brandonroberts added a commit that referenced this issue Dec 7, 2017
brandonroberts added a commit to brandonroberts/platform that referenced this issue Dec 7, 2017
brandonroberts added a commit that referenced this issue Dec 11, 2017
brandonroberts added a commit that referenced this issue Dec 12, 2017
brandonroberts added a commit to brandonroberts/platform that referenced this issue Dec 12, 2017
@kuncevic
Copy link

kuncevic commented Dec 13, 2017

is there any documantation on codegen and schematics yet?

@MikeRyanDev
Copy link
Member

@kuncevic No, we have a lot more work to do before we consider either of those projects released.

@kuncevic
Copy link

kuncevic commented Dec 13, 2017

@MikeRyanDev both saying "version": "4.1.1", in package.json so I thought that is something that ready to go.

@MikeRyanDev
Copy link
Member

MikeRyanDev commented Dec 13, 2017

No, they are not published to NPM. That version number in package.json is a byproduct of the release process for our other packages.

@RoopeHakulinen
Copy link

@MikeRyanDev I would be interested in testing once you think it is ready for it and I'd be willing to help with documentation also if necessary.

@ghost
Copy link

ghost commented Dec 15, 2017

@MikeRyanDev I am also interested in testing and would be willing to help with documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants