Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(RouterStore): Match RouterAction type parameters #562

Merged
merged 1 commit into from
Nov 15, 2017

Conversation

livthomas
Copy link
Contributor

I am sending a fix for the bug reported as #561.

You should probably consider better names for type parameters (for example R for router state and S for store state) since now T and V are used quite wildly in the code and every time they mean something different. But I did not want to do such big changes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 92.813% when pulling c2cfe6f on livthomas:router-action-type into ab5ad56 on ngrx:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants