Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(StoreDevtools): Recompute state history when reducers are updated #844

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

brandonroberts
Copy link
Member

This fixes the issue with time-traveling to previous states before the reducers were updated. Each state history item will be recomputed with the latest reducer.

This fixes the issue with time-traveling to previous states before
the reducers were updated. Each state history item will be recomputed
with the latest reducer.
@MikeRyanDev
Copy link
Member

This is the same behavior as Redux's devtools, right?

@brandonroberts
Copy link
Member Author

Mostly. The difference is that the history is recomputed with the @ngrx/store/update-reducers action instead of the original one.

@MikeRyanDev MikeRyanDev merged commit 10debcc into master Feb 20, 2018
@MikeRyanDev MikeRyanDev deleted the devtools-state-history branch February 20, 2018 03:12
sandangel pushed a commit to sandangel/platform that referenced this pull request Mar 23, 2018
…ngrx#844)

This fixes the issue with time-traveling to previous states before
the reducers were updated. Each state history item will be recomputed
with the latest reducer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants