Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting a selector out of a library complains of Dictionary cannot be named #865

Closed
ymcnicoll opened this issue Feb 26, 2018 · 1 comment

Comments

@ymcnicoll
Copy link

ymcnicoll commented Feb 26, 2018

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[X] Bug report  
[ ] Feature request
[ ] Documentation issue or request

What is the current behavior?

When compiling a library using Ng-Packagr I get errors from un-exported types used by selectors. I dont get this error if using Reselect to create selectors.

Part of the issue is caused by Entity using un-exported Dictionary type for its entities.

Expected behavior:

Compiling without errors

Minimal reproduction of the problem with instructions:

  1. create a project following sample from ng-packagr.
  2. create module withing the project with feature and selectors
  3. build

Other information:

@peterbsmyth
Copy link

@ymcnicoll would you provide a stackblitz or repo or similar example to reproduce then I can PR for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants