fix(Store): only default to initialValue when store value is undefined #886
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This assumes the store will only have an
undefined
state on initialization and sets theinitialSate
at that time. If the store state ever becomesundefined
again in the future it will be reset to theinitialState
again. This basically meansinitialState
is more of a "default state" then "initial", but this at least improves it to be an undefined-check instead of falsey-check. If we wanted to change this to be more strictly an "initial" state then this change would grow quite a bit.For example if you add the following diff to the tests weird things occur: