feat(service): add option to set default language in root config #1105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hello and thanks for the PR, it's a good idea, but can you rebase it on master and remove the code formatting changes (it makes it hard to see the actual changes, and creates lots of conflicts) |
|
@ocombe I have done the changes as you recommended. Please review and let me know in case you have any concerns. |
…Now user can specifiy defaultLanguage while specifiying the other configuration at the time of registering the module with the application. Code formatted with prettifier
ocombe
approved these changes
Feb 12, 2020
ocombe
changed the title
|
https://github.com/ngx-translate/core/pull/1105/files#diff-04c6e90faac2675aa89e2176d2eec7d8R242 Why set the default lang again if it was set in the root config? btw. in markdown, if you use only |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default language option added for specifying the language at the time of defining the configuration in
forRootorforChildmethod.Now user don't need to explicitly calls the
setRootLanguagemethod for defining the default language at the initial time.Code formatted.
Example added for
defaultLanguage.