Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[BUG]: Weird indentation on ngxs-logger (is the cancelComplete: true working?) #1657

Open
saffabook opened this issue Aug 17, 2020 · 6 comments

Comments

@saffabook
Copy link

Affected Package

The issue is caused by package @ngxs-logger-plugin.js

Description

Weird indentation on ngxs-logger.

I am following this tutorial, particularly the {cancelCompleted: true} functionality for NGXS.

If you follow the video, you will see him click quickly on an order to demonstrate how the request is cancelled followed by a new request. However in his example, his ngxs-logger, the console log indents with the request, and then it all resets when completed. I have an image of it below. Also you can see several green Next State comments. Also have a look at the video to see what I mean.
image

However with mine, my ngxs-logger remains indented and never resets. I have an image below to explain what I mean. Also I have only one green next state despite clicking multiple times. My server is on a 3 second delay so I can mimic any lag. Does this lag have anything to do with it?
image

Hi I have written a more in depth article on stack overflow.

I have the exact code I am using on Stackblitz

Why would my ngxs-logger behave differently to the tutorial.

Many thanks.

@splincode
Copy link
Member

@arturovt what do you think?

@saffabook
Copy link
Author

anybody out there?

@splincode
Copy link
Member

@ngxs/core ping

@saffabook
Copy link
Author

@ngxs/core ping ping ding aling?

@splincode
Copy link
Member

@saffabook if you can investigate problem, maybe will be can you create PR for fix current bug?

@kovaldenys96
Copy link

kovaldenys96 commented Sep 14, 2020

I have the similar issue.
So, I dispatch event with async handler multiple times and cancel all of them. After it, all new actions will be logged on the some level above in the console (equivalent to the canceled actions).

important to note that actions are really canceled, just logging-plugin doesn't reset the depth of logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants