Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADOExceptionReporter logs errors without a stack trace #3584

Open
justaszal opened this issue Jul 9, 2024 · 0 comments
Open

ADOExceptionReporter logs errors without a stack trace #3584

justaszal opened this issue Jul 9, 2024 · 0 comments

Comments

@justaszal
Copy link

justaszal commented Jul 9, 2024

Hello,

The ADOExceptionReporter does not include the stack trace for error logs, only warnings. The problem is that our application is configured to not log warnings for NHibernate, and we cannot see the stack trace of the error logs in our observability system.

while (ex != null)
{
log.Warn(ex, ex.Message);
log.Error(ex.Message);
ex = ex.InnerException;
}

We propose to log errors like this: log.Error(ex, ex.Message).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant