Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: getHTML() API result includes placeholder html #2301

Merged
merged 2 commits into from
Mar 17, 2022
Merged

fix: getHTML() API result includes placeholder html #2301

merged 2 commits into from
Mar 17, 2022

Conversation

js87zz
Copy link
Contributor

@js87zz js87zz commented Feb 10, 2022

Please check if the PR fulfills these requirements

  • It's the right issue type on the title
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • It does not introduce a breaking change or has a description of the breaking change

Description

Thank you for your contribution to TOAST UI product. 🎉 😘 ✨

@jwlee1108 jwlee1108 merged commit 5dd9efb into master Mar 17, 2022
@jwlee1108 jwlee1108 deleted the fix/placeholder-getHTML branch March 17, 2022 05:20
ahamelers pushed a commit to ahamelers/tui.editor that referenced this pull request Aug 21, 2023
@js87zz
fix: getHTML() API result includes placeholder html (nhn#2301)
9e57aea 
* fix: placeholder cannot be removed when calling getHTML API
* chore: add test case(placeholder)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwlee1108 jwlee1108 jwlee1108 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@js87zz @jwlee1108