Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in react-editor README.md file #2743

Closed
D0Dam opened this issue Sep 20, 2022 · 6 comments
Closed

Typo in react-editor README.md file #2743

D0Dam opened this issue Sep 20, 2022 · 6 comments
Labels

Comments

@D0Dam
Copy link
Contributor

D0Dam commented Sep 20, 2022

Describe the bug

There is a typo in the README.md file.

To Reproduce

The typo is in the code written in the 'Instance Methods' of 'Usage'.
스크린샷 2022-09-20 오전 11 48 42

handleClick function is wrong, It must be change like this.

  handleClick = () => {
   // type error!!
   // this.editorRef.current.getInstance().exec('Bold'); 
   // Change the first letter of 'Bold' to lowercase.
      this.editorRef.current.getInstance().exec('bold');
  };

Check console.log like this, we can see that 'bold' is defined.

const handleClick = () => {
console.log(editorRef.current.getInstance().commandManager.wwCommands);
  };

스크린샷 2022-09-20 오후 12 34 52

Desktop (please complete the following information):

  • OS: iOS
  • Browser: chrome
  • Version: 22

Additional context

Add any other context about the problem here.

@D0Dam D0Dam added the Bug label Sep 20, 2022
@jwlee1108
Copy link
Contributor

@D0Dam Thank you for the issue. I'll fix it later. Are you willing to contribute to fix it?

@D0Dam
Copy link
Contributor Author

D0Dam commented Sep 21, 2022

@D0Dam Thank you for the issue. I'll fix it later. Are you willing to contribute to fix it?

@jwlee1108
Oh! Yes, I willing to contribute to that. Thank you for accepting issue.
And If I want to contribute, do I have to send PR?

@jwlee1108
Copy link
Contributor

@D0Dam Yes. I want you to follow the template when you open the PR. Our team is busy with other projects these days, so I can't check it right away, but I'll check it as soon as possible.

@D0Dam
Copy link
Contributor Author

D0Dam commented Sep 21, 2022

Thank you for your explanation. I will send the PR according to the template as soon as possible.

@D0Dam
Copy link
Contributor Author

D0Dam commented Sep 28, 2022

Here is opened PR : #2746

@jwlee1108
Copy link
Contributor

@D0Dam It merged. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants