Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error summary markup needs to be updated to follow GOV.UK #1035

Open
edwardhorsford opened this issue Sep 27, 2024 · 1 comment · May be fixed by #1036 or NHSDigital/nhsuk-react-components#255
Open

Error summary markup needs to be updated to follow GOV.UK #1035

edwardhorsford opened this issue Sep 27, 2024 · 1 comment · May be fixed by #1036 or NHSDigital/nhsuk-react-components#255

Comments

@edwardhorsford
Copy link
Contributor

Bug Report

Whilst testing the error summary with VoiceOver on Safari, I observe that 'There is a problem' gets read out twice. I think this is because the error summary itself is aria-labelledby the title, and then Voiceover also reads the contents of the error summary - first of which is the title.

Comparing to GOV.UK, their markup updated in v4.4 to move the alert to a child element and adjust other bits for screen readers.
@edwardhorsford edwardhorsford linked a pull request Sep 27, 2024 that will close this issue
Open
3 tasks
@edwardhorsford
Copy link
Contributor Author

Video of error summary title getting read out twice:
https://github.com/user-attachments/assets/5144e891-ef00-479e-a573-8f312ac3e782

@edwardhorsford edwardhorsford linked a pull request Sep 27, 2024 that will close this issue
Open
@rowellx68 rowellx68 mentioned this issue Sep 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@edwardhorsford