From e09308db48c29a7f8d9874a3c10afe4d7ef7be59 Mon Sep 17 00:00:00 2001
From: Michael Cheung <michaelcheung@nhs.net>
Date: Fri, 28 Oct 2022 15:07:19 +0100
Subject: [PATCH] Add role=list to lists to fix VoiceOver not announcing as
 lists

---
 CHANGELOG.md                                   | 5 +++++
 packages/components/do-dont-list/template.njk  | 2 +-
 packages/components/error-summary/template.njk | 2 +-
 3 files changed, 7 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 06942ef1d..f8ba0ef7f 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -1,5 +1,10 @@
 # NHS.UK frontend Changelog
 
+## 6.1.3 - TBA
+
+:wrench: **Fixes**
+- Fix issue with VoiceOver on Safari (iOS and macOS) not announcing a list as a list. This affects some components that have a list with style `list-style-type: none`, ie those that have a class of `nhsuk-list` on the `<ul>`. This fixes the do/don't list and the error summary components. The contents list and pagination components don't seem to be affected.
+
 ## 6.1.2 - 8 August 2022
 
 :wrench: **Fixes**
diff --git a/packages/components/do-dont-list/template.njk b/packages/components/do-dont-list/template.njk
index c0904c0bf..bd28d3bd6 100644
--- a/packages/components/do-dont-list/template.njk
+++ b/packages/components/do-dont-list/template.njk
@@ -3,7 +3,7 @@
 {%- if params.classes %} {{ params.classes }}{% endif %}"
 {%- for attribute, value in params.attributes %} {{attribute}}="{{value}}"{% endfor %}>
   <h{{ headingLevel }} class="nhsuk-do-dont-list__label">{{ params.title }}</h{{ headingLevel }}>
-  <ul class="nhsuk-list {% if params.type == 'tick' %}nhsuk-list--tick{% else %}nhsuk-list--cross{% endif %}">
+  <ul class="nhsuk-list {% if params.type == 'tick' %}nhsuk-list--tick{% else %}nhsuk-list--cross{% endif %}" role="list">
     {%- for data in params.items %}
     <li>
     {%- if params.type == 'cross' %}
diff --git a/packages/components/error-summary/template.njk b/packages/components/error-summary/template.njk
index 95efc518b..dda1cd4d0 100644
--- a/packages/components/error-summary/template.njk
+++ b/packages/components/error-summary/template.njk
@@ -10,7 +10,7 @@
       {{ params.descriptionHtml | safe if params.descriptionHtml else params.descriptionText }}
     </p>
     {% endif -%}
-    <ul class="nhsuk-list nhsuk-error-summary__list">
+    <ul class="nhsuk-list nhsuk-error-summary__list" role="list">
     {%- for item in params.errorList %}
       <li>
       {%- if item.href %}