Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate all errors in one enum type in a file #384

Open
sanmut opened this issue Mar 22, 2018 · 0 comments
Open

Consolidate all errors in one enum type in a file #384

sanmut opened this issue Mar 22, 2018 · 0 comments

Comments

@sanmut
Copy link
Contributor

sanmut commented Mar 22, 2018

I think we should consolidate all errors (such as kQueueArgErr, kFormatTypeMismatch) in one header file, preferably under one enum. We can have duplicate names with the same value such as for Argument Errors on different nodes/features.

We also have code like these:
errPtr->SetErrorAndAppendCallChain(true, kVariantIncompatibleType, "Get Variant Attribute");
Instead of using a hardcoded string we need to do string constants and consolidate them in a single place. We also need to consider localization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant