Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot set breakpoints within storybook stories #2066

Closed
mollykreis opened this issue May 2, 2024 · 6 comments · Fixed by storybookjs/storybook#27171 or #2283
Closed

Cannot set breakpoints within storybook stories #2066

mollykreis opened this issue May 2, 2024 · 6 comments · Fixed by storybookjs/storybook#27171 or #2283
Assignees

Comments

@mollykreis
Copy link
Contributor

🧹 Tech Debt

After storybook was moved to its own package, you can no longer set breakpoints within the storybook files (e.g. button.stories.ts). Setting breakpoints within a component's source does work correctly while running storybook.

@mollykreis mollykreis added tech debt triage New issue that needs to be reviewed labels May 2, 2024
@mollykreis mollykreis changed the title Cannot set breakpoints within storybook files Cannot set breakpoints within storybook stories May 2, 2024
@m-akinc m-akinc self-assigned this May 2, 2024
@m-akinc
Copy link
Contributor

m-akinc commented May 2, 2024

I synced back to a commit from the end of February, and I still see the same behavior, i.e. <component>.stories.ts does not show up in debugger (only <component>-tests-<component>-stories.iframe.bundle.js) and attempting to put a breakpoint on the equivalent lines in the bundle file results in the message Could not load content for webpack://ni/nimble-components/ (Fetch through target failed: Unsupported URL scheme; Fallback: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME).

Given that it wasn't a simple configuration problem introduced when moving to the new storybook package (or even necessarily a regression), I'm going to stop my investigation here.

@m-akinc m-akinc removed their assignment May 2, 2024
@fredvisser
Copy link
Contributor

I assume these are related? – storybookjs/storybook#26954 & storybookjs/storybook#26653

@m-akinc m-akinc added blocked Blocked on a third-party issue and removed triage New issue that needs to be reviewed labels May 7, 2024
@valentinpalkovic
Copy link

valentinpalkovic commented May 22, 2024

@fredvisser Could you please try out the canary release of Storybook 0.0.0-pr-27171-sha-f81ba26a for testing purposes and let me know whether it fixes your issues related to source maps? Related PR: storybookjs/storybook#27171

If you're using @storybook/addon-coverage please also update it to use the following canary release: 1.0.4--canary.42.041aa23.0. Related PR: storybookjs/addon-coverage#42

@fredvisser
Copy link
Contributor

@valentinpalkovic - It looks like the Storybook canary release works well - thanks!

(We aren't using @storybook/addon-coverage, so we didn't test that one).

@m-akinc
Copy link
Contributor

m-akinc commented Jun 5, 2024

Storybook 8.2.0 should contain the fix. Check their releases to see if it has been released yet.

@valentinpalkovic
Copy link

The release of 8.2.0 is planned for this week!

@jattasNI jattasNI self-assigned this Jul 17, 2024
@jattasNI jattasNI removed the blocked Blocked on a third-party issue label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging a pull request may close this issue.

5 participants