feat: Add client for Artifacts API #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
vignesh-ni
requested review from
mure,
spanglerco and
cameronwaterman
as code owners
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
nisystemlink/clients/artifact/models/_upload_artifact_request.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
MuthuRajan-S
approved these changes
Sep 2, 2024
Madhan-Reddy-ni
requested changes
Sep 2, 2024
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
Madhan-Reddy-ni
approved these changes
Sep 2, 2024
|
@mure , @spanglerco , @cameronwaterman. Gentle remainder to review this PR |
|
@vignesh-ni I was out sick last week and have a bunch of reviews piled up. I should get to this tomorrow. |
cameronwaterman
approved these changes
Sep 4, 2024
mure
requested changes
Sep 4, 2024
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
|
@mure @spanglerco A gentle remainder to review the PR.. |
|
@vignesh-ni @Madhan-Reddy-ni I'm deferring to @mure's review, which he's already provided. If you need a re-review, there's a button at the top in the reviewers section to re-request a review: Not all of the code owners review every PR in this repo. |
|
@vignesh-ni Looks like the build is failing at the lint step |
mure
approved these changes
Sep 6, 2024
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
Signed-off-by: Vigneshwaran Selvaraj <vigneshwaran.selvaraj@ni.com>
vignesh-ni
force-pushed
the
users/vignesh/artifact-client
branch
from
a03a055
to
dd6a79d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Check the above box with an 'x' indicating you've read and followed CONTRIBUTING.md.
What does this Pull Request accomplish?
This PR adds client methods for all of the
artifactsendpoints and testing for these endpoints.Why should this Pull Request be merged?
This is an client for artifact APIs and will enable users to more easily interact with that APIs.
What testing has been done?
Auto testing is included against NI's test tier.
API Link: Swagger-link