Skip to content

Commit

Permalink
fix: ensure look images fully cover wrappers
Browse files Browse the repository at this point in the history
This patch updates the scores header to ensure that the preview look
image properly covers the entire section to fill. Previously, this issue
was not so readily apparent until I started importing all the shows from
Vogue. Not every show on Vogue has the same aspect ratio of look image.
This ensures that they appear to, at least, on my website.
  • Loading branch information
nicholaschiang committed Jul 25, 2023
1 parent 4e67bcd commit a11ba75
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion app/routes/shows.$showId/route.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function Looks({ className }: { className: string }) {
<li key={look.id}>
<div className='bg-gray-100 dark:bg-gray-900 aspect-person'>
<img
className='object-cover h-full'
className='object-cover h-full w-full'
src={look.image.url}
alt=''
/>
Expand Down
2 changes: 1 addition & 1 deletion app/routes/shows.$showId/scores-header.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ export function ScoresHeader() {
<div className='flex gap-2'>
<div className='flex-none w-40 bg-gray-100 dark:bg-gray-900 h-0 min-h-full'>
<img
className='object-cover h-full'
className='object-cover h-full w-full'
src={show.looks[0].image.url}
alt=''
/>
Expand Down
2 changes: 1 addition & 1 deletion app/routes/shows._index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export default function ShowsPage() {
<Link to={`/shows/${show.id}`}>
<div className='bg-gray-100 dark:bg-gray-900 aspect-person mb-2'>
<img
className='object-cover h-full'
className='object-cover h-full w-full'
src={show.looks[0].image.url}
alt=''
/>
Expand Down

0 comments on commit a11ba75

Please sign in to comment.