Skip to content

Commit

Permalink
fix(routes/show): links to sections show headers
Browse files Browse the repository at this point in the history
This patch updates the show page styling so that an anchor-based link
(`#`) to a specific section on the show page will include that show's
header. Previously, the show's header was being hidden by the top app
bar. Now, I moved the gap between sections to the section padding
itself, which makes the section headings appear when linking directly to
them.
  • Loading branch information
nicholaschiang committed Jul 23, 2023
1 parent b6348ba commit bd37e47
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion app/routes/shows.$showId/route.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ function Looks({ className }: { className: string }) {

function About({ className }: { className: string }) {
return (
<div className={cn('overflow-auto grid gap-10', className)}>
<div className={cn('overflow-auto', className)}>
<ScoresHeader />
<WhatToKnow />
<WhereToBuy />
Expand Down
2 changes: 1 addition & 1 deletion app/routes/shows.$showId/section.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export function Section({
children,
}: PropsWithChildren<{ id: string; header: string }>) {
return (
<section className='grid gap-2' id={id}>
<section className='grid gap-2 pt-10' id={id}>
<h1 className='border-l-2 border-emerald-700 pl-1.5 font-medium text-base uppercase'>
{header}
</h1>
Expand Down

0 comments on commit bd37e47

Please sign in to comment.