Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
114336: roachprod-microbench: read-only sheet permissions r=renatolabs a=herkolategan

Previously sheets were open to editing for anyone with the link. But since sheets may be publicly shared it should be set to read-only. And since sheets are not the source of truth or record it should not be used as a discussion area.

This change updates the permissions of sheets to be read-only (view only).

Epic: None
Release Note: None

Co-authored-by: Herko Lategan <herko@cockroachlabs.com>
  • Loading branch information
craig[bot] and herkolategan committed Nov 14, 2023
2 parents d061b0d + 80ad183 commit b3d6b39
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/roachprod-microbench/google/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ func (srv *Service) updatePerms(ctx context.Context, spreadsheetID string) error
// with the link.
perm := &drive.Permission{
Type: "anyone",
Role: "writer",
Role: "reader",
}
_, err := srv.drive.Permissions.Create(spreadsheetID, perm).Context(ctx).Do()
return errors.Wrap(err, "update Spreadsheet permissions")
Expand Down

0 comments on commit b3d6b39

Please sign in to comment.