Skip to content
This repository has been archived by the owner on Oct 26, 2022. It is now read-only.

If PR is rejected, automatically add Changes Needed label #2

Open
awitherow opened this issue Feb 23, 2017 · 4 comments
Open

If PR is rejected, automatically add Changes Needed label #2

awitherow opened this issue Feb 23, 2017 · 4 comments
Labels
help wanted

Comments

@awitherow
Copy link
Contributor

Also notify the creator?

  • slack channel ?
  • comment in PR?
@nicolai86
Copy link
Owner

@awitherow can you describe in more detail what you mean by "rejected"?

@awitherow
Copy link
Contributor Author

  1. either by a reviewer
  2. a failing test.

Those were my two ideal cases. Thoughts?

@nicolai86
Copy link
Owner

Thanks for the clarification.

I'm not sure how much noise this would generate, as e.g. branches which are not yet ready for review will probably have lots of failing tests. Do you think it's a good idea to perform these actions before the author declares her branch ready to be reviewed?

@awitherow
Copy link
Contributor Author

Nope, only if the review needed label is present.

@nicolai86 nicolai86 changed the title If PR rejected, automatically add Changes Needed label If PR rebase fails, automatically add Changes Needed label May 6, 2017
@nicolai86 nicolai86 changed the title If PR rebase fails, automatically add Changes Needed label If PR is rejected, automatically add Changes Needed label May 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nicolai86 @awitherow