Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_work needs a return value #4

Open
petrakohorst opened this issue Mar 14, 2018 · 2 comments
Open

add_work needs a return value #4

petrakohorst opened this issue Mar 14, 2018 · 2 comments
Assignees

Comments

@petrakohorst
Copy link

The sub add_work should return (at least) the put-code-url, and for good measure the result code.

@nics
Copy link
Owner

nics commented Mar 16, 2018

Are you sure?
Adding this minimal record to the sandbox correctly returns the put code for me:
{
"title":{"title":"Foo"},
"type":"JOURNAL_ARTICLE",
"external-ids": {
"external-id":[{
"external-id-type": "doi",
"external-id-value": "10.1016/j.jdeveco.2017.10.010",
"external-id-relationship": "SELF"
}]
}
}
Adding this invalid record correctly sets last error:
{
"title":{"title":"Foo"},
"type":"JOURNAL_ARTICLE",
"external-ids": {
"external-id":[{
"external-id-type": "doi"
}]
}
}

@petrakohorst
Copy link
Author

I'll have to check my implementation again. Maybe I'm sending an incorrect record or I have a bug somewhere else along the line.
Thank you for testing this! I'll get back to you with more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants