Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use structures for input/output arguments in pd_gmres #37

Open
jhabriel opened this issue Nov 28, 2023 · 1 comment
Open

Use structures for input/output arguments in pd_gmres #37

jhabriel opened this issue Nov 28, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request priority:medium This issue must be handle soon

Comments

@jhabriel
Copy link
Collaborator

Things got out of hand...

We got to a point where we have too many input arguments and too many output arguments.

After #28 is tackled, we will have to re-refactor the signature of the function using structures. We can have a call of the type

[x, extraOutputArgs] = pd_gmres(A, b, extraInputArgs, varargin);

where extraOutputArgs and extraInputArgs are respectively the extra output and input arguments.

@jhabriel jhabriel added enhancement New feature or request priority:medium This issue must be handle soon labels Nov 28, 2023
@jhabriel jhabriel self-assigned this Nov 28, 2023
@jhabriel
Copy link
Collaborator Author

Another alternative could be:

[x, flag, relresvec, mvec, time] = pd_gmres(A, b, mInitial, extraInputs, varargin);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:medium This issue must be handle soon
Projects
None yet
Development

No branches or pull requests

1 participant