Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for identity matrix are failing #66

Closed
gusespinola opened this issue Jul 3, 2024 · 2 comments · Fixed by #67
Closed

Tests for identity matrix are failing #66

gusespinola opened this issue Jul 3, 2024 · 2 comments · Fixed by #67

Comments

@gusespinola
Copy link
Collaborator

gusespinola commented Jul 3, 2024

Greetings! I am trying to put the GMRES-E algorithm back on track, but I am dealing with bugs when trying to solving the toy linear system

eye(n) * x = ones(n, 1)

The failures are in test_gmres_e/test_outputs_unrestarted_identity_matrix and test_outputs_restarted_identity_matrix.

Could you please check what would be the expected solution? Thanks in advance!

@jhabriel
Copy link
Collaborator

jhabriel commented Jul 6, 2024

I noticed that the branch is 20 commits behind the main branch. Can you try merging the main branch into 63-gmres-e and then we take it from there?

@gusespinola gusespinola linked a pull request Jul 9, 2024 that will close this issue
@jhabriel
Copy link
Collaborator

I believe I solved this issue. It was relate to a too many input arguments situation. However, I encountered another unexpected behaviour, which I reported in #68. We need to address that error before merging this solver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants