Add Tests for ChipWithIcon Component issue #39 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ChipWithIconComponentWithTransformText.test = async (browser, { component }) => { | ||
| browser.expect(component).to.be.visible; | ||
| browser.expect.element('[data-testid="chip-icon"]').to.be.present; | ||
| browser.expect(component).text.to.equal('sample chip'); |
There was a problem hiding this comment.
transformText converts sample chip to Sample chip
There was a problem hiding this comment.
do i need to add other test with "sample chip" and expect "Sample chip" ??
There was a problem hiding this comment.
or just change the values and keep it two tests ??
There was a problem hiding this comment.
@vaibhavsingh97
when enable the transformText it did not convert sample chip to Sample chip
as you can see
with test
I don't get it
- it works fine in the app
- in the test it dose the opposite
I think this happens because the inner component <Text> ,maybe
so what do you think ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive tests for the
ChipWithIconcomponent to ensure it renders correctly under various conditions. The new tests verify that the component behaves as expected when different icons and text transformation properties are applied.Key highlights include:
transformTextprop.Resolves #39