fix zindex bug #1978
Closed
fix zindex bug #1978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasvh
added a commit
that referenced
this pull request
Sep 22, 2019
niklasvh
added a commit
that referenced
this pull request
Sep 22, 2019
* fix zindex bug * test: add z-index reftest for #1978 * fix: z-index ordering early exit
pawelzwronek
pushed a commit
to pawelzwronek/html2canvas
that referenced
this pull request
Oct 13, 2019
* fix zindex bug * test: add z-index reftest for niklasvh#1978 * fix: z-index ordering early exit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since my English sucks, machine translation can only be translated!
i found one problem.
if we have a html like:
https://codepen.io/tianchouczl/pen/PoYGOQK
if the numbers of absolute positioning div > 2 have this bug
in stacking-context.ts lines:113-122
let index = 0; parentStack.positiveZIndex.some((current, i) => { if (order > current.element.container.styles.zIndex.order) { index = i + 1; return true; } return false; }); parentStack.positiveZIndex.splice(index, 0, stack);this index not true. we should found the index which is less then order.but this code, if u got the first order less then order, u return true.This is not what we want.
example:
if parentStack.positiveZIndex have two index [1,2]
and we give a order = 3
in this code ,we got parentStack.positiveZIndex = [1,3,2],
but we need [1,2,3]