Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snake cases should be Camel cases #16

Open
gpetrousov opened this issue Oct 29, 2018 · 3 comments
Open

Snake cases should be Camel cases #16

gpetrousov opened this issue Oct 29, 2018 · 3 comments

Comments

@gpetrousov
Copy link

Good practices and syntax sugar for Golang

@nikotrone
Copy link
Owner

I see no snake cases in the project, only 2 times when i used SF_something instead of SalesforceSomething or salesforceSomething.

@gpetrousov
Copy link
Author

I'm working on setting up a travis file so you can do automatic CI with linting. By running the linter manually, I get the following. It's not really an issue, but a nice addition to the project. 😃

src/GoS2S3/App.go:39:6: don't use underscores in Go names; var SF_Soap should be SFSoap
src/GoS2S3/App.go:40:6: don't use underscores in Go names; var SF_BasicAuth should be SFBasicAuth
...
src/GoS2S3/ConfLoader.go:49:2: don't use underscores in Go names; struct field Instance_url should be InstanceURL
src/GoS2S3/ConfLoader.go:51:2: don't use underscores in Go names; struct field Access_key_ID should be AccessKeyID
src/GoS2S3/ConfLoader.go:52:2: don't use underscores in Go names; struct field Secret_access_key should be SecretAccessKey
src/GoS2S3/ConfLoader.go:53:2: don't use underscores in Go names; struct field Session_token should be SessionToken
src/GoS2S3/ConfLoader.go:56:2: don't use underscores in Go names; struct field S3_destination_bucket should be S3DestinationBucket
src/GoS2S3/ConfLoader.go:57:2: don't use underscores in Go names; struct field S3_destination_path should be S3DestinationPath
src/GoS2S3/ConfLoader.go:58:2: don't use underscores in Go names; struct field S3_destination_prefix should be S3DestinationPrefix

@nikotrone
Copy link
Owner

I did to maintain the name of the variable similar as the json variable name (for immediate find when searching in the project). Obviously if there are better reason for changing those variables i can refactor the code :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants