Skip to content
This repository has been archived by the owner on Oct 11, 2020. It is now read-only.

Cannot full support Domain restrictive Inverse type options #101

Closed
lychichem opened this issue Jan 13, 2018 · 5 comments
Closed

Cannot full support Domain restrictive Inverse type options #101

lychichem opened this issue Jan 13, 2018 · 5 comments

Comments

@lychichem
Copy link

lychichem commented Jan 13, 2018

Describe the issue

ublock edge cannot full support Domain restrictive Inverse type options

One or more specific URLs where the issue occurs

https://weibo.com/ (Maybe an account is needed)

Screenshot in which the issue can be seen

Bad:
bad
Good:
good

Steps for anyone to reproduce the issue

  1. Install a custom filter from https://raw.githubusercontent.com/523860169/list/master/ad.txt
  2. Open weibo.com
  3. Many functions relates to js.t.sinajs.cn/open/analytics/js/suda.js will not work. The screenshoot above show one of them, that is, the emoji panel will be in bad mode. (althouth there is actually a whitelist @@||sinajs.cn/open/analytics/js/suda.js$domain=weibo.com|~widget.weibo.com)
  4. Add a custom whitelist @@||sinajs.cn/open/analytics/js/suda.js$domain=weibo.com
  5. All function at weibo.com will work fine.

Your settings

Only use filter above and cancel other filters.

  • OS/version: Windows 10 x64 build 16299.162 pro version
  • Browser/version: Microsoft Edge 16.16299
  • uBlock Origin version: 1.14.23
Your filter lists

No

Your custom filters (if any)

https://raw.githubusercontent.com/523860169/list/master/ad.txt

@lychichem
Copy link
Author

@523860169 I've submitted the issue I talked with you just now here, is there anything I forgot to say here? Or did I say something wrong? Please give additional information if needed.

@gorhill
Copy link

gorhill commented Jan 13, 2018

It's a problem in uBO core it seems, I will fix asap.

gorhill added a commit to gorhill/uBlock that referenced this issue Jan 13, 2018
@lychichem
Copy link
Author

@gorhill Thanks for your fix. I've sideloaded your fix version of ublock and see it works as expected. Now it's time for @nikrolls to merge.

@nicole-ashley
Copy link
Owner

@lychichem, can you please confirm if this is fixed in 1.14.24?

@lychichem
Copy link
Author

@nikrolls Yes, it was fixed on 1.14.24.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants