Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhantomJS should be listed as a dependency for running tests. #4

Closed
samrat opened this issue Mar 13, 2018 · 3 comments
Closed

PhantomJS should be listed as a dependency for running tests. #4

samrat opened this issue Mar 13, 2018 · 3 comments

Comments

@samrat
Copy link

samrat commented Mar 13, 2018

Running lein test without PhantomJS installed throws an error. The README should probably mention that PhantomJS should be installed before running tests.
@kirang89
Copy link
Contributor

This had completely slipped my mind. I've fixed this in #c07c7d.

Thanks for pointing this out :)

@palfrey
Copy link
Contributor

palfrey commented Nov 5, 2018

Turns out that PhantomJS 1.9.7 (which I had installed) isn't enough. 2.1.1 which I replaced it with was.

@kirang89
Copy link
Contributor

@palfrey I've updated the README to add a note about using Phantom 2.x. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@palfrey @samrat @kirang89