Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callbacks added with asyncfutures.addCallback are invoked in reverse order #7197

Closed
endragor opened this issue Feb 9, 2018 · 0 comments
Closed
Labels
Async Everything related to Nim's async Standard Library

Comments

@endragor
Copy link
Contributor

endragor commented Feb 9, 2018

I expected that addCallback respects the order in which I add callbacks, but turns out it calls them in reverse order - each new callback is prepended to the linked list, instead of being appended. I think it makes more sense to append them, especially given the name (in stdlib "add" always appends), and there are use cases where ordering is important.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Async Everything related to Nim's async Standard Library
Projects
None yet
Development

No branches or pull requests

3 participants
@andreaferretti @endragor and others