compiler: don't raise when NodeJS is missing #812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Don't raise an exception when the NodeJS executable cannot be found.
In case that NodeJS is missing, this fixes:
compiler when a
runnableExample
is encounteredtestament
aborting a category when attempting to run the first JStest
In addition, this also means that the compiler now exits with a proper
error instead of crashing because of an unhandled exception.
Details
This is a revert of commit 0ae2d1e.
Except for one, all callsites of
findNodeJS
expect an empty string incase a NodeJS installation cannot be found and use that information to
handle the error themselves:
docgen
handles it by not runningrunnableExamples
andtestament
treats and reports the affected testas failed.
The only place where a missing NodeJS installation wasn't handled, and
what the reverted commit intended to fix, is the processing of the
run
(or
-r
) option. There, the path is now verified to not be empty and anerror is reported (via
logError
) if it is.