codegen: remove obsolete mReset support
#827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Remove the code generation logic for the unused `mReset` magic from all three code generators. Details ======= With the last usage of `specializeReset` gone, the `ccgreset` module is obsolete now and thus removed. The `parentObj` procedure previously defined in it is inlined at its single callsite in `ccgexprs`.
zerbina
added
compiler/backend
saem
approved these changes
Aug 7, 2023
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below: |
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the code generation logic for the unused
mResetmagic from allthree code generators.
Details
With the last usage of
specializeResetgone, theccgresetmoduleis obsolete now and thus removed. The
parentObjprocedure previouslydefined in the module is inlined at the single callsite in
ccgexprs.