testament: decouple production of TestRuns
#829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Separate production of test-run descriptions (`TestRun`) from actually executing them, which slightly flattens the call hierarchy and makes it easier to pass additional configuration state to execution. Details ======= Instead of directly executing the runs, `testSpec` (which is renamed to `produceRuns`) appends the descriptions to a provided list, leaving how to execute the runs to the callsite. The `testSpecWithNimcache` routine is only used with custom categories, where sequential execution is, in most cases, required, so it still executes the runs directly. The new `run` procedure takes a slice of tests runs and executes them. Both the legacy `testSpec` overload and `processCategory` use it for executing the runs produced by `produceRuns`. In theory, it is now possible to first collect the runs for all non- special-category tests before executing any of them.
zerbina
added
refactor
saem
approved these changes
Aug 7, 2023
|
/merge |
|
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Separate production of test-run descriptions (
TestRun) from actuallyexecuting them, which slightly flattens the call hierarchy and
makes it easier to pass additional configuration state to execution.
Details
Instead of directly executing the runs,
testSpec(which is renamed toproduceRuns) appends the descriptions to a provided list, leavinghow to execute the runs to the callsite. The
testSpecWithNimcacheroutine is only used with custom categories, where sequential execution
is, in most cases, required, so it still executes the runs directly.
The new
runprocedure takes a slice of tests runs and executes them.Both the legacy
testSpecoverload andprocessCategoryuse it forexecuting the runs produced by
produceRuns.In theory, it is now possible to first collect the runs for all non-
special-category tests before executing any of them.