remove support for enum inheritance #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary ======= Enum types supported an internal base type that could only be specified in macro-generated enum types (there's no syntax for representing it), but weren't aren't any tests for it, the features seems to have never been documented anywhere, and enums that inherit from other enums are not consistently considered in the compiler. The feature is thus removed. Details ======= - remove support for `nkEnumTy` AST having a non-empty first slot. This now results in an `illformed AST` error - remove support for enum inheritance from `tryReadingTypeField` - remove the `rsemInheritanceOnlyWorksWithAnEnum` report
zerbina
added
compiler/sem
saem
approved these changes
Aug 10, 2023
|
/merge |
|
Merge requested by: @zerbina Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enum types supported an internal base type that could only be specified
in macro-generated enum types (there's no syntax for representing it),
but there aren't any tests for it, the features seems to have never
been documented anywhere, and enums that inherit from other enums are
not consistently considered in the compiler. The feature is thus
removed.
Details
nkEnumTyAST having a non-empty first slot. Thisnow results in an
illformed ASTerrortryReadingTypeFieldrsemInheritanceOnlyWorksWithAnEnumreport