tool: nimsuggest remove terse flag
#898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saem
added
tool
|
@bung87 please see the PR, there is a part of the original body that I can't work out what you mean, can you add more info, I'll help with the grammar? Also, note how I changed the body, including reviewer notes. These messages are not simply for the PR review now, but also for future retrospectives, someone putting together change logs, learning from the compiler etc... so we ensure they do a good job describing the goal, change, and impact. |
|
After the PR body is updated this is good to merge, |
bung87
changed the title
terse flag from nimsuggestterse flag
|
/merge |
|
Merge requested by: @saem Contents after the first section break of the PR description has been removed and preserved below:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove
terseflag fromnimsuggest. It's not used by any of theexisting extensions, nor is it tested.
Details
The option itself is rather arbitrary in what it filters and the design
is confusing in terms of determining what should and shouldn't qualify.