Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vm: Remove mStaticExec and opcGorge #909

Merged
merged 1 commit into from
Sep 16, 2023
Merged

vm: Remove mStaticExec and opcGorge #909

merged 1 commit into from
Sep 16, 2023

Conversation

Clyybber
Copy link
Contributor

@Clyybber Clyybber commented Sep 16, 2023 •
edited by github-actions bot
Loading

Summary

  • Remove mStaticExec and opcGorge as only the csources compiler
    needs to have them in order to bootstrap

Details

@Clyybber Clyybber added compiler/vm Embedded virtual machine simplification Removal of the old, unused, unnecessary or un/under-specified language features. and removed simplification Removal of the old, unused, unnecessary or un/under-specified language features. labels Sep 16, 2023
zerbina
zerbina approved these changes Sep 16, 2023
View reviewed changes
Copy link
Collaborator

@zerbina zerbina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

I've added a line break in the PR body to get it to a line length of 72 characters.

@saem saem added the simplification Removal of the old, unused, unnecessary or un/under-specified language features. label Sep 16, 2023
@saem
Copy link
Collaborator

saem commented Sep 16, 2023

/merge

Thanks, @Clyybber.

@github-actions
Copy link

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:

@chore-runner chore-runner bot added this pull request to the merge queue Sep 16, 2023
Merged via the queue into nim-works:devel with commit f98ba58 Sep 16, 2023
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zerbina zerbina zerbina approved these changes

Assignees
No one assigned
Labels
compiler/vm Embedded virtual machine simplification Removal of the old, unused, unnecessary or un/under-specified language features.
Projects
None yet
Milestone
VM refactoring and improvements
Development

Successfully merging this pull request may close these issues.
3 participants
@Clyybber @saem @zerbina