Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove disabled code in modulepaths.nim #911

Merged
merged 1 commit into from
Sep 17, 2023

Conversation

bung87
Copy link
Contributor

@bung87 bung87 commented Sep 16, 2023

Summary

Remove disabled code related to nimble in modulepaths, it was left
over from a long ago (6+ years) disabled import feature related to
nimble. Since we'll have a new package manager anyways, not bothering
to investigate it any further.

Details

  • Remove constants considerParentDirs, considerNimbleDirs
  • Remove procedures findInNimbleDir, resolveDollar,scriptableImport,
    lookupPackage
  • Remove lookupPackage disabled usage in getModuleName

@bung87 bung87 changed the title remove disabled code in modulepaths over 6 years remove disabled code in modulepaths.nim over 6 years Sep 16, 2023
@saem
Copy link
Collaborator

saem commented Sep 16, 2023

@bung87 the long term plan is not for me to write all of your PR messages. Please look back at the changes I've made in previous PRs and clean-up this and all the other PRs.

@bung87
Copy link
Contributor Author

bung87 commented Sep 16, 2023

I know that, but this is for clean up, I don't have much reason in my mind to be written.

@zerbina zerbina changed the title remove disabled code in modulepaths.nim over 6 years remove disabled code in modulepaths.nim Sep 16, 2023
@saem saem added compiler General compiler tag simplification Removal of the old, unused, unnecessary or un/under-specified language features. labels Sep 16, 2023
@saem
Copy link
Collaborator

saem commented Sep 16, 2023

I know that, but this is for clean up, I don't have much reason in my mind to be written.

I know it's tempting, I feel the same way some times, but over and over again experience has shown that it doesn't pay off in this code base.

Copy link
Collaborator

@saem saem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job removing all this deadcode, @bung87

@saem
Copy link
Collaborator

saem commented Sep 16, 2023

/merge

@github-actions
Copy link

Merge requested by: @saem

Contents after the first section break of the PR description has been removed and preserved below:


Notes for Reviewers

  • Simplifies the code base

@chore-runner chore-runner bot added this pull request to the merge queue Sep 16, 2023
Merged via the queue into nim-works:devel with commit 6b19275 Sep 17, 2023
18 checks passed
@bung87 bung87 deleted the cleanup-modulepaths branch September 28, 2023 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler General compiler tag simplification Removal of the old, unused, unnecessary or un/under-specified language features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants