Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRUD] Add the index view templates to the generator #492

Closed
malparty opened this issue Dec 19, 2023 · 0 comments · Fixed by #505
Closed

[CRUD] Add the index view templates to the generator #492

malparty opened this issue Dec 19, 2023 · 0 comments · Fixed by #505
Assignees
@khangbui22
Labels
type : feature

Comments

@malparty
Copy link
Member

Why

The default view generator in Rails does not include Bootstrap classes and has a poor layout. To make the generator usable out of the box, the Rails template must ship with custom view templates.

  • This story only focuses on the index view.
  • Ensure the template is using the SLIM engine

Who Benefits?

Green field project teams.
@khangbui22 khangbui22 self-assigned this Jan 11, 2024
khangbui22 added a commit that referenced this issue Mar 6, 2024
@khangbui22
[#492] Update Gemfile to include slim-rails instead of slim
56bd163
khangbui22 added a commit that referenced this issue Mar 6, 2024
@khangbui22
[#492] Update template code and slim template index file
6742028
@khangbui22 khangbui22 mentioned this issue Mar 6, 2024
Merged
4 tasks
khangbui22 added a commit that referenced this issue Mar 6, 2024
@khangbui22
[#492] Fix rubocop issue
1117266
khangbui22 added a commit that referenced this issue Mar 6, 2024
@khangbui22
[#492] Fix spec test
e3fe83d
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Improve copy_template_files function for easier readability
fdbea78
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Update Gemfile to include slim-rails instead of slim
46febab
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Update template code and slim template index file
2b96835
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Fix rubocop issue
6f7bf33
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Fix spec test
398d851
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Improve copy_template_files function for easier readability
b17ce32
khangbui22 added a commit that referenced this issue Mar 7, 2024
@khangbui22
[#492] Fix rubocop error
01f07e5
khangbui22 added a commit that referenced this issue Mar 8, 2024
@khangbui22
[#492] Remove unused method
45faaf9
khangbui22 added a commit that referenced this issue Mar 8, 2024
@khangbui22
[#492] Move ThorUtils to a lib
8efd953
khangbui22 added a commit that referenced this issue Mar 8, 2024
@khangbui22
[#492] Fix rubocop
dde7303
khangbui22 added a commit that referenced this issue Mar 8, 2024
@khangbui22
[#492] Fix rubocop
792ab36
github-merge-queue bot pushed a commit that referenced this issue Mar 13, 2024
@khangbui22 @malparty
[#492][CRUD] Add the index view templates to the generator (#505)
688614e 
* [#483] Add tests to the CRUD layout

* [#483] Fix the check for slim and erb layout files

* [#492] Update Gemfile to include slim-rails instead of slim

* [#492] Update template code and slim template index file

* [#492] Fix rubocop issue

* [#492] Fix spec test

* [#492] Improve copy_template_files function for easier readability

* [#492] Fix rubocop error

* [#492] Remove unused method

* [#492] Move ThorUtils to a lib

* [#492] Fix rubocop

* [#492] Fix rubocop

---------

Co-authored-by: Xavier MALPARTY <xavier@nimblehq.co>
@malparty malparty mentioned this issue Mar 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@khangbui22 khangbui22

Labels
type : feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#492][CRUD] Add the index view templates to the generator nimblehq/rails-templates
2 participants
@khangbui22 @malparty