Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There should be a binning tool in MultiDimensionalProcessing #40

Open
1 task
Brow71189 opened this issue Jul 3, 2024 · 4 comments
Open
1 task

There should be a binning tool in MultiDimensionalProcessing #40

Brow71189 opened this issue Jul 3, 2024 · 4 comments
Labels
audience - user affects users effort - day a day or less impact - high has difficult or onerous workaround reach - medium affects several users weekly

Comments

@Brow71189
Copy link
Collaborator

Brow71189 commented Jul 3, 2024

To Do

Preview Give feedback
  1. 0 of 2
    audience - user effort - week f - computations f - processing feature impact - high needs planning reach - medium type - enhancement
@TomaSusi
Copy link

TomaSusi commented Jul 3, 2024

Request from Vienna!

@cmeyer
Copy link
Contributor

cmeyer commented Jul 3, 2024

I'm close enough to implementing the general case of applying any processing to sequences/collections that I think we could focus our effort on (a) doing that; (b) implementing the 2D binning algorithm nicely; (c) providing reduction options for all potential coordinate sets.

To that end, is there anything more to the binning for an individual 2D element than "reduce by number of pixels"?

And, is there anything unique about binning in the collection/sequence coordinate systems?

@cmeyer cmeyer added audience - user affects users effort - day a day or less impact - high has difficult or onerous workaround reach - medium affects several users weekly labels Jul 3, 2024
@Brow71189
Copy link
Collaborator Author

I think having a binning that can bin any axis of a multi-D dataset will be enough. So probably your general case will work.
We just need to make sure this is fast, i.e. don't do any weird resampling but simplay sum groups of neighboring pixels, just like camera binning does.

@TomaSusi
Copy link

TomaSusi commented Jul 4, 2024

The py4DSTEM guys have some code to handle edges that might be worth glancing at:
https://github.com/py4dstem/py4DSTEM/blob/dev/py4DSTEM/preprocess/preprocess.py#L155

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience - user affects users effort - day a day or less impact - high has difficult or onerous workaround reach - medium affects several users weekly
Projects
None yet
Development

No branches or pull requests

3 participants