Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export batch with no boxes checked overwrites same file repeatedly #586

Closed
4 tasks
cmeyer opened this issue Dec 15, 2020 · 4 comments
Closed
4 tasks

Export batch with no boxes checked overwrites same file repeatedly #586

cmeyer opened this issue Dec 15, 2020 · 4 comments
Assignees
Labels
audience - user affects users effort - day a day or less f - IO good first issue good for newcomers impact - medium has straightforward but non-obvious workaround reach - small affects a few users weekly type - bug

Comments

@cmeyer
Copy link
Collaborator

cmeyer commented Dec 15, 2020

When the user is exporting a set of files by selecting multiple display items and then choosing File > Export, the user is presented with a dialog that allows them to set the file naming template.

image

If they deselect all items, or if the combination of check boxes results in duplicate filenames, the export procedure simply overwrites the earlier export with the same filename.

Tasks

Preview Give feedback
@cmeyer cmeyer added this to the Next Bug Fix Release milestone Dec 15, 2020
@cmeyer cmeyer added the good first issue good for newcomers label Apr 17, 2021
@cmeyer
Copy link
Collaborator Author

cmeyer commented Aug 16, 2021

XY reports "If I export multiple data with the same name (e.g. NionCCD-1010), only one file can be saved. I can check "Include Sequence Number" to allow them all to be saved. However, could you make this batch export smarter to automatically add sequence numbers if several items use the same file name."

@cmeyer cmeyer self-assigned this Aug 16, 2021
@cmeyer cmeyer removed their assignment Oct 27, 2021
@cmeyer
Copy link
Collaborator Author

cmeyer commented Nov 15, 2021

The UI for the batch export resides in ExportDialog.py.

Once the user has configured the options, the do_export method loops through the selected display items and exports them to a file using write_display_item_with_writer.

@cmeyer
Copy link
Collaborator Author

cmeyer commented Jun 12, 2024

Fixed 907bf56

@Ion-e
Copy link

Ion-e commented Jul 15, 2024

Issue verified as working correctly.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audience - user affects users effort - day a day or less f - IO good first issue good for newcomers impact - medium has straightforward but non-obvious workaround reach - small affects a few users weekly type - bug
Projects
None yet
Development

No branches or pull requests

4 participants