Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dseg conversions should have integral data types #2001

Closed
oesteban opened this issue Feb 26, 2020 · 2 comments
Closed

dseg conversions should have integral data types #2001

oesteban opened this issue Feb 26, 2020 · 2 comments
Assignees
@mgxd
Labels
bug derivatives effort: low Estimated low effort task good first issue impact: medium Estimated medium impact task
Milestone
20.2.0 LTS

Comments

@oesteban
Copy link
Member

Currently have float32

cc/ @ericearl
@oesteban oesteban added bug good first issue derivatives impact: medium Estimated medium impact task effort: low Estimated low effort task labels Feb 26, 2020
@oesteban oesteban added this to the 20.0.1 milestone Feb 26, 2020
@effigies
Copy link
Member

This changes outputs for good runs, meaning if somebody processes two subjects, one runs fine on 20.0.0 and the other needs a fix in 20.0.1, then the outputs will differ based on whether they rerun the good subject.

@oesteban oesteban modified the milestones: 20.0.1, 20.1.0 Feb 26, 2020
@effigies
Copy link
Member

I'm seeing mask files as float32, as well. They should be uint8.

@oesteban oesteban modified the milestones: 20.1.x, 20.1.0 LTS Mar 25, 2020
@mgxd mgxd mentioned this issue Apr 1, 2020
Merged
@mgxd mgxd closed this as completed Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mgxd mgxd

Labels
bug derivatives effort: low Estimated low effort task good first issue impact: medium Estimated medium impact task
Projects
None yet
Milestone
20.2.0 LTS
Development

No branches or pull requests
3 participants
@effigies @oesteban @mgxd