Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

20.2.8 release? #3329

Closed
effigies opened this issue Jul 18, 2024 · 5 comments
Closed

20.2.8 release? #3329

effigies opened this issue Jul 18, 2024 · 5 comments

Comments

@effigies
Copy link
Member

I've updated the LTS changelog post-20.2.7 (Jan 2022):

fmriprep/CHANGES.rst

Lines 1 to 21 in 51cbfed

20.2.8 (To be determined)
=========================
Bug-fix release in the 20.2.x LTS series.
* FIX: Select volumetric dseg.tsv from recent TemplateFlow releases (#3257)
* FIX: LTS package build (#3328)
* DOC: Read html_baseurl from RTD environment, if available (#3324)
* DOCKER: Pin conda environment more strictly (#2853)
* MNT: Require niworkflows ~1.3.6 (#2740)
* CI: Upgrade docker orb (#2865)
This release includes a number of fixes that have accumulated in niworkflows,
including the following fixes that affect fMRIPrep:
* FIX: Remove unused ANTs parameter that was removed in 2.4.1 (nipreps/sdcflows#431)
* FIX: Limit 3dQwarp to maximum 4 CPUs for stability reasons (nipreps/sdcflows#128)
* MAINT: Make call to scipy.stats.mode compatible with scipy 1.11.0 (nipreps/sdcflows#371)
* FIX: TSV2JSON should convert empty TSV files to empty JSON files (nipreps/niworkflows#747)
* FIX: Use copy function that does not preserve mtime when creating fsaverage
directories (nipreps/niworkflows#703)
* FIX: Set pixdim[4] to match RepetitionTime (nipreps/niworkflows#679)

Bug-fix PRs:

Most of the fixes affect tests, resolve bugs discovered in our own uses (which abandoned 20.2.x a long time ago), or fix problems for users building their own environments (and the niworkflows/sdcflows releases resolved those).

Only nipreps/niworkflows#679 addresses a specific user-reported bug in our published containers. Given that it came 2 months after the 20.2.7 release, we were probably expecting more, but it's been two more years and almost all PRs are just keeping the thing building.

Should we go ahead and release? Or is 20.2.7 demonstrably "fine" at this point? @bpinsard @mgxd @HippocampusGirl?

Diffs:

@HippocampusGirl
Copy link
Contributor

This sounds like a great idea! I'm all in favor of keeping the LTS going with new patch releases (at least until there is a new major LTS release)

@mgxd
Copy link
Collaborator

mgxd commented Jul 18, 2024

Agreed on cutting a new release - no bug fix left behind!

@effigies
Copy link
Member Author

We would like to have a new LTS by the end of the year. I don't think I want to extend 20.2.x beyond the original Sept 2024 support period, given the difficulty of keeping images building with the same versions of Python packages.

That said, we've been able to sit on 20.2.7 for two years, so I think we can tentatively count on 20.2.8 being a final release.

@bpinsard
Copy link
Collaborator

It's a great idea to have a final release.

@effigies
Copy link
Member Author

https://github.com/nipreps/fmriprep/releases/tag/20.2.8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants