Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add non-blocking pings #34

Open
mgxd opened this issue Apr 26, 2023 · 0 comments · May be fixed by #52
Open

Add non-blocking pings #34

mgxd opened this issue Apr 26, 2023 · 0 comments · May be fixed by #52
Labels
enhancement New feature or request

Comments

@mgxd
Copy link
Collaborator

mgxd commented Apr 26, 2023

What would you like to see added in this software?

Currently, the common way to communicate with the server is to call add_project(), which blocks and waits for a server response. In (rare) cases where the server is unavailable, this can cause a delay equal to the value of the request timeout.

I think in the long run, a better solution would be:

  • Separate requests where server response is expected from those that it is not (related to Reduce server egress migas-server#66)
  • Refactor the request to be done within a concurrent.futures.ThreadPoolExecutor to avoid blocking the main thread.

Do you have any interest in helping implement the feature?

Yes

Additional information / screenshots

No response

@mgxd mgxd added the enhancement New feature or request label Apr 26, 2023
@mgxd mgxd linked a pull request Oct 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant