Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML report folder structure does not work for ongoing longitudinal out of the box #350

Open
tjhendrickson opened this issue Mar 21, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@tjhendrickson
Copy link

What happened?

The way that the HTML reports does not work well with the use case of an ongoing longitudinal study.

For example here is screenshot of a the high level directory tree of nibabies
image

Notice that the HTML report sub-XXX.html and figures folders either relate only to the subject or are within the subject folder. With this design and the proposed use case, the data for a given subject would have to be entirely re-processed each time an additional scanning session is added.

I propose the following high level directory tree to account for this:
image

Perhaps you could add a flag such as --longitudinal-study-reporting that a user could specify for this? Certainly don't want to propose a change to the default structure, but it is important to consider this use case

What command did you use?

Run Nibabies on a subject with one study session and then re-run with another study session

What version of NiBabies are you using?

N/A

Relevant log output

No response

Add any additional information or context about the problem here.

No response

@tsalo
Copy link
Contributor

tsalo commented Mar 28, 2024

Just to clarify, why would you need to reprocess all sessions each time a scanning session is added? It seems like running Nibabies with your specified session would just add to the output directory. The current directory structure doesn't seem to have anything that would conflict across sessions, since the session ID is in the HTML filename and figures should have the session ID in their names as well.

@tsalo
Copy link
Contributor

tsalo commented Mar 28, 2024

Note from today's Nibabies meeting: there isn't a problem, since the figures will have the session entity in the filenames, but making this change would make the file organization cleaner.

EDIT: @mgxd noted that the FreeSurfer derivatives need to be organized longitudinally.
EDIT 2: That's already tracked in #288.

@tsalo
Copy link
Contributor

tsalo commented Mar 29, 2024

I've thought about it a bit more and it doesn't make sense to me to put the HTML reports inside the subject's folder, never mind the subject's session-wise folders. We don't put subject-level HTML reports in the subject folders, do we? Also, if you want to copy session-wise nibabies derivatives, you're still going to need to copy top-level files from the derivatives dataset to make sense of the session-wise derivatives anyway, so moving the HTML report doesn't affect portability.

I do think that writing out figures to the session level folder does make sense though, since you won't need to filter the subject-level figures folder when you copy out a session's data.

@tsalo
Copy link
Contributor

tsalo commented Nov 21, 2024

QSIRecon now has a parameter to control where reports go: --report-output-level {root,subject,session}. We're planning to implement it in QSIPrep and XCP-D as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants