-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: improved brain extraction parameters #44
ENH: improved brain extraction parameters #44
Conversation
Hello @eilidhmacnicol! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2021-02-23 09:16:57 UTC |
d002efd
to
a058c54
Compare
Now running on CircleCI, but ran into an issue that seems to have been discussed already (nipreps/niworkflows#619), so have updated to niworkflows 1.4.0rc4 (see: nipreps/niworkflows#599), but an alternative fix is also on the horizon (nipreps/niworkflows#619) |
4ce4355
to
b2f420c
Compare
Update: the pin of niworkflows 1.4.0rc4 didn't help, as the |
5397796
to
b98035d
Compare
Pinned svgutils to 0.3.1 as recommended as the quick fix in (nipreps/niworkflows#595) while waiting for the more permanent fix to be included in the release candidate. Now tests are passing (and results look quite good if I say so myself). @oesteban WDYT? What would be best to upstream to niworkflows? Should I merge first and then refactor? |
Needs testing on a more diverse dataset, but this works very well on 24 fairly isotropic T2w images.
Could test with the original dataset on Sherlock and then upstream the N4 changes to niworkflows as part of nipreps/niworkflows#611 if further improvements aren't needed.