STY: Assorted refurb suggestions #831
Merged
+7
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
d06a8c5
to
88328a5
Compare
DimitriPapadopoulos
force-pushed
the
refurb
branch
2 times, most recently
from
962b5ef
to
19da814
Compare
effigies
reviewed
Oct 13, 2023
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
08546ff
to
e26a13b
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #831 +/- ##
=======================================
Coverage 63.08% 63.08%
=======================================
Files 53 53
Lines 6252 6247 -5
Branches 913 913
=======================================
- Hits 3944 3941 -3
+ Misses 2121 2119 -2
Partials 187 187
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
effigies
reviewed
Oct 14, 2023
https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow Because naive datetime objects are treated by many datetime methods as local times, it is preferred to use aware datetimes to represent times in UTC. As such, the recommended way to create an object representing the current time in UTC is by calling datetime.now(timezone.utc). Deprecated since version 3.12: Use datetime.now() with UTC instead. Co-authored-by: Chris Markiewicz <effigies@gmail.com>
DimitriPapadopoulos
force-pushed
the
refurb
branch
from
e26a13b
to
1ab45f0
Compare
effigies
approved these changes
Oct 15, 2023
effigies
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returnat end of function andx = x)utcnow()→now(tz=timezone.utc)From https://docs.python.org/3/library/datetime.html#datetime.datetime.utcnow: