Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base workflow: generate output fields as synchronized lists of elements #147

Closed
oesteban opened this issue Dec 11, 2020 · 0 comments · Fixed by #149
Closed

Base workflow: generate output fields as synchronized lists of elements #147

oesteban opened this issue Dec 11, 2020 · 0 comments · Fixed by #149
Labels
effort: low Estimated low effort task enhancement New feature or request impact: high Estimated high impact task pipelines
Milestone
2.0.0

Comments

@oesteban
Copy link
Member

That will make the SDCFlows outputs look as if they were generated by NiPype's MapNode. Then, we can use NiWorkflows' KeySelect to connect the appropriate output for each EPI target that must be corrected.
@oesteban oesteban added enhancement New feature or request impact: high Estimated high impact task effort: low Estimated low effort task pipelines labels Dec 11, 2020
@oesteban oesteban added this to the 2.0.0 milestone Dec 11, 2020
oesteban added a commit to josephmje/dmriprep that referenced this issue Dec 11, 2020
@oesteban
enh: general refactor
917c35c 
- Connections to the particular ``dwi_file`` are done within the
  particular run's preproc workflow, using ``KeySelect`` to demux
  the available fieldmap options.
  This relies on implementing nipreps/sdcflows#147 and
  nipreps/sdcflows#148.
- Minimizes the overhead in ``dmriprep/workflows/base.py``
oesteban added a commit to oesteban/sdcflows that referenced this issue Dec 11, 2020
@oesteban
ENH: Multiplex fieldmap estimation outputs into a single outputnode
e8ac4fc 
Allows for an interface similar to that of *sMRIPrep*, which enables using
``KeySelect`` nodes to find the appropriate connections downstream.

Required-by: nipreps/dmriprep#140.
Resolves: nipreps#147.
@oesteban oesteban mentioned this issue Dec 11, 2020
Merged
oesteban added a commit to josephmje/dmriprep that referenced this issue Dec 11, 2020
@oesteban
enh: general refactor
d0ac22c 
- Connections to the particular ``dwi_file`` are done within the
  particular run's preproc workflow, using ``KeySelect`` to demux
  the available fieldmap options.
  This relies on implementing nipreps/sdcflows#147 and
  nipreps/sdcflows#148.
- Minimizes the overhead in ``dmriprep/workflows/base.py``
- Run black
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: low Estimated low effort task enhancement New feature or request impact: high Estimated high impact task pipelines
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

ENH: Multiplex fieldmap estimation outputs into a single outputnode oesteban/sdcflows
1 participant
@oesteban